Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/files logging #1286

Merged
merged 17 commits into from
Aug 15, 2024
Merged

fix/files logging #1286

merged 17 commits into from
Aug 15, 2024

Conversation

jenbutongit
Copy link
Contributor

@jenbutongit jenbutongit commented Aug 14, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please also include any acceptance criteria if you have any.

  • Add additional pre handlers that handle files to improve readability
    • getFiles is responsible checking the payload for any readable streams (i.e. files), files are assigned to request.pre.files
    • validateContentTypes reads the files from getFiles and checks their content type. This will also detect if the user did not upload anything for this field. It will attempt to find a previously uploaded file so the user can continue
  • Refactored uploadService.handleUploadRequest into a pre handler, which calls uploadService
  • Add additional logging for all steps
  • Fix bug where we stopped showing "You have already provided this file"
    • This has now been changed to show the filename the user has uploaded, it now displays "You previously uploaded the file '..'"
    • The summary page can also display filenames if enabled. In the form json, add: "showFilenamesOnSummaryPage": true
Screenshots

Screenshot 2024-08-15 at 13 44 25

image (7)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce
the testing if necessary.

  • Unit
  • Manual
  • Smoke tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and versioning
  • I have updated the architecture diagrams as per Contribute.md OR added an architectural decision record entry

@jenbutongit jenbutongit merged commit a0017fd into main Aug 15, 2024
13 checks passed
@jenbutongit jenbutongit deleted the fix/files-logging branch August 15, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants